Checkstyle Results
The following document contains the results of
Checkstyle.
Summary
| Files | Infos | Warnings | Errors |
|---|
| 154 | 0 | 0 | 1778 |
Files
com/pow2/dao/AbstractDAO.java
| Error | Line |
|---|
| Line does not match expected header line of ' Version 1.1'. |
2
|
|
| Using the '.*' form of import should be avoided - java.sql.*. |
26
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
27
|
|
| Using the '.*' form of import should be avoided - org.apache.commons.beanutils.*. |
29
|
|
| Using the '.*' form of import should be avoided - org.apache.log4j.*. |
30
|
|
| Using the '.*' form of import should be avoided - com.pow2.resources.*. |
32
|
|
| Variable 'cat' must be private and have accessor methods. |
45
|
|
| Line is longer than 80 characters. |
51
|
|
| Line has trailing spaces. |
61
|
|
| Line is longer than 80 characters. |
66
|
|
| Method 'isDebugEnabled' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
| Line is longer than 80 characters. |
80
|
|
| Method 'assertion' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
| Parameter tableName should be final. |
85
|
|
| Parameter condition should be final. |
85
|
|
| Line is longer than 80 characters. |
94
|
|
| Method 'count' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
| Parameter tableName should be final. |
98
|
|
| Line is longer than 80 characters. |
107
|
|
| Line is longer than 80 characters. |
108
|
|
| Method 'count' is not designed for extension - needs to be abstract, final or empty. |
112
|
|
| Parameter tableName should be final. |
112
|
|
| Parameter condition should be final. |
112
|
|
| 'if' construct must use '{}'s. |
118
|
|
| Method 'getNewKey' is not designed for extension - needs to be abstract, final or empty. |
131
|
|
| Method 'delete' is not designed for extension - needs to be abstract, final or empty. |
147
|
|
| Parameter tableName should be final. |
147
|
|
| Parameter condition should be final. |
147
|
|
| Method 'delete' is not designed for extension - needs to be abstract, final or empty. |
176
|
|
| Parameter tableName should be final. |
176
|
|
| Parameter condition should be final. |
177
|
|
| Parameter con should be final. |
178
|
|
| 'if' construct must use '{}'s. |
186
|
|
| 'if' construct must use '{}'s. |
203
|
|
| 'if' construct must use '{}'s. |
205
|
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
219
|
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
233
|
|
| Parameter isolationLevel should be final. |
233
|
|
| Method 'setLike' is not designed for extension - needs to be abstract, final or empty. |
252
|
|
| Parameter value should be final. |
252
|
|
| Line is longer than 80 characters. |
262
|
|
| Method 'setLike' is not designed for extension - needs to be abstract, final or empty. |
267
|
|
| Parameter value should be final. |
267
|
|
| Parameter upperCase should be final. |
267
|
|
| Parameter likeMode should be final. |
267
|
|
| '?' should be on a new line. |
269
|
|
| Avoid inline conditionals. |
269
|
|
| Line is longer than 80 characters. |
270
|
|
| Line is longer than 80 characters. |
271
|
|
| 'if' construct must use '{}'s. |
273
|
|
| Method 'encode' is not designed for extension - needs to be abstract, final or empty. |
287
|
|
| Parameter statement should be final. |
287
|
|
| 'if' construct must use '{}'s. |
294
|
|
| 'else' construct must use '{}'s. |
296
|
|
| Line is longer than 80 characters. |
309
|
|
| Method 'populate' is not designed for extension - needs to be abstract, final or empty. |
317
|
|
| Parameter bean should be final. |
317
|
|
| Parameter resultSet should be final. |
317
|
|
| 'for' construct must use '{}'s. |
329
|
|
| Method 'closeResources' is not designed for extension - needs to be abstract, final or empty. |
355
|
|
| Parameter con should be final. |
355
|
|
| Parameter commit should be final. |
355
|
|
| Method 'closeResources' is not designed for extension - needs to be abstract, final or empty. |
373
|
|
| Parameter st should be final. |
373
|
|
| Parameter con should be final. |
373
|
|
| Parameter commit should be final. |
373
|
|
| Method 'closeResources' is not designed for extension - needs to be abstract, final or empty. |
392
|
|
| Parameter rs should be final. |
392
|
|
| Parameter st should be final. |
393
|
|
| Parameter con should be final. |
394
|
|
| Parameter commit should be final. |
395
|
|
| 'if' construct must use '{}'s. |
398
|
|
| 'if' construct must use '{}'s. |
399
|
|
| 'if' construct must use '{}'s. |
400
|
|
| Parameter con should be final. |
436
|
|
| Parameter commit should be final. |
437
|
|
| Parameter close should be final. |
438
|
|
| 'catch' is not followed by whitespace. |
473
|
|
| 'if' construct must use '{}'s. |
475
|
|
| Line is longer than 80 characters. |
483
|
|
| Line is longer than 80 characters. |
485
|
|
| 'if' construct must use '{}'s. |
492
|
|
| 'if' construct must use '{}'s. |
495
|
|
| 'catch' is not followed by whitespace. |
498
|
|
| Line is longer than 80 characters. |
500
|
|
| 'if' construct must use '{}'s. |
505
|
|
| 'else' construct must use '{}'s. |
507
|
|
| Line is longer than 80 characters. |
526
|
|
| Parameter tableName should be final. |
526
|
|
| Parameter query should be final. |
526
|
|
| Parameter fieldName should be final. |
526
|
|
| 'if' construct must use '{}'s. |
539
|
com/pow2/dao/Condition.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - com.pow2.util.*. |
29
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
41
|
|
| Variable 'cat' must be private and have accessor methods. |
41
|
|
| Name 'condition' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
70
|
|
| Name 'firstBooleanOperatorSize' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
73
|
|
| Line is longer than 80 characters. |
88
|
|
| Line is longer than 80 characters. |
91
|
|
| Line is longer than 80 characters. |
92
|
|
| Line is longer than 80 characters. |
94
|
|
| Parameter attributeName should be final. |
98
|
|
| Parameter op should be final. |
99
|
|
| Parameter attributeValue should be final. |
100
|
|
| Parameter encloseInBrackets should be final. |
101
|
|
| Line is longer than 80 characters. |
111
|
|
| Line is longer than 80 characters. |
113
|
|
| Line is longer than 80 characters. |
114
|
|
| Line is longer than 80 characters. |
118
|
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
118
|
|
| Parameter booleanOp should be final. |
118
|
|
| Parameter cnd should be final. |
118
|
|
| Parameter encloseInBrackets should be final. |
118
|
|
| Line is longer than 80 characters. |
130
|
|
| Avoid inline conditionals. |
140
|
|
| Line is longer than 80 characters. |
144
|
|
| Line is longer than 80 characters. |
146
|
|
| Line is longer than 80 characters. |
147
|
|
| Avoid inline conditionals. |
147
|
|
| Line is longer than 80 characters. |
159
|
|
| Line is longer than 80 characters. |
160
|
|
| Line is longer than 80 characters. |
170
|
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
175
|
|
| Parameter attributeName should be final. |
175
|
|
| Parameter op should be final. |
176
|
|
| Parameter attributeValue should be final. |
177
|
|
| Parameter encloseInBrackets should be final. |
178
|
|
| Line is longer than 80 characters. |
187
|
|
| Line is longer than 80 characters. |
197
|
|
| Line is longer than 80 characters. |
199
|
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
213
|
|
| Parameter booleanOp should be final. |
213
|
|
| Parameter attributeName should be final. |
214
|
|
| Parameter op should be final. |
215
|
|
| Parameter attributeValue should be final. |
216
|
|
| Parameter encloseInBrackets should be final. |
217
|
|
| Expected @param tag for 'encloseInBrackets'. |
217
|
|
| Line is longer than 80 characters. |
224
|
|
| '||' should be on a new line. |
226
|
|
| '||' should be on a new line. |
227
|
|
| '||' should be on a new line. |
228
|
|
| Line is longer than 80 characters. |
231
|
|
| Avoid inline conditionals. |
247
|
|
| Avoid inline conditionals. |
253
|
|
| 'if' construct must use '{}'s. |
258
|
|
| Line is longer than 80 characters. |
258
|
|
| Method 'clear' is not designed for extension - needs to be abstract, final or empty. |
269
|
|
| Method 'isEmpty' is not designed for extension - needs to be abstract, final or empty. |
281
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
292
|
|
| Method 'encloseInBrackets' is not designed for extension - needs to be abstract, final or empty. |
304
|
|
| 'if' construct must use '{}'s. |
306
|
|
| Line is longer than 80 characters. |
309
|
|
| Parameter cond should be final. |
327
|
com/pow2/dao/ConnectionFactory.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Class ConnectionFactory should be declared as final. |
42
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
| Name 'provider' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
51
|
|
| 'if' construct must use '{}'s. |
69
|
|
| Parameter prefs should be final. |
82
|
|
| 'cast' is not followed by whitespace. |
86
|
|
| Line is longer than 80 characters. |
90
|
|
| Line is longer than 80 characters. |
97
|
|
| Line is longer than 80 characters. |
107
|
|
| Parameter isolationLevel should be final. |
114
|
com/pow2/dao/ConnectionProvider.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.sql.*. |
27
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
|
| Variable 'cat' must be private and have accessor methods. |
44
|
|
| Name 'prefs' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
47
|
|
| Variable 'prefs' must be private and have accessor methods. |
47
|
|
| Method 'getPrefs' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
| Method 'setPrefs' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Parameter prefs should be final. |
76
|
|
| 'prefs' hides a field. |
76
|
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
| Parameter isolationLevel should be final. |
106
|
|
| Method 'getLastToken' is not designed for extension - needs to be abstract, final or empty. |
123
|
|
| Parameter str should be final. |
123
|
|
| Parameter tokenSeparator should be final. |
123
|
com/pow2/dao/ConnectionProviderPrefs.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
29
|
|
| Name 'connectionProviderClass' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
40
|
|
| Name 'connectionPoolURL' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
|
| Name 'jdbcDriver' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
46
|
|
| Name 'jdbcURL' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
|
| Name 'user' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
52
|
|
| Name 'password' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
55
|
|
| Name 'properties' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
58
|
|
| Line is longer than 80 characters. |
62
|
|
| Method 'getConnectionProviderClass' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
| Method 'getConnectionPoolURL' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
| Method 'getJdbcURL' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
| Method 'getJdbcDriver' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
| Method 'getPassword' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
| Method 'getUser' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
| Method 'setUser' is not designed for extension - needs to be abstract, final or empty. |
132
|
|
| Parameter user should be final. |
132
|
|
| 'user' hides a field. |
132
|
|
| Method 'setPassword' is not designed for extension - needs to be abstract, final or empty. |
143
|
|
| Parameter password should be final. |
143
|
|
| 'password' hides a field. |
143
|
|
| Method 'setJdbcURL' is not designed for extension - needs to be abstract, final or empty. |
154
|
|
| Parameter jdbcURL should be final. |
154
|
|
| 'jdbcURL' hides a field. |
154
|
|
| Method 'setJdbcDriver' is not designed for extension - needs to be abstract, final or empty. |
165
|
|
| Parameter jdbcDriver should be final. |
165
|
|
| 'jdbcDriver' hides a field. |
165
|
|
| Method 'setConnectionPoolURL' is not designed for extension - needs to be abstract, final or empty. |
176
|
|
| Parameter connectionPoolURL should be final. |
176
|
|
| 'connectionPoolURL' hides a field. |
176
|
|
| Line is longer than 80 characters. |
183
|
|
| Method 'setConnectionProviderClass' is not designed for extension - needs to be abstract, final or empty. |
187
|
|
| Parameter connectionProviderClass should be final. |
187
|
|
| 'connectionProviderClass' hides a field. |
187
|
|
| Method 'getProperties' is not designed for extension - needs to be abstract, final or empty. |
198
|
|
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. |
209
|
|
| Parameter properties should be final. |
209
|
|
| 'properties' hides a field. |
209
|
com/pow2/dao/DAO.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line has trailing spaces. |
6
|
|
| Line has trailing spaces. |
11
|
|
| Line has trailing spaces. |
13
|
|
| Line has trailing spaces. |
14
|
|
| Line has trailing spaces. |
17
|
|
| Line has trailing spaces. |
18
|
|
| Line has trailing spaces. |
20
|
|
| Line has trailing spaces. |
21
|
|
| Line contains a tab character. |
52
|
|
| 'if' construct must use '{}'s. |
63
|
com/pow2/dao/HTMLDAO.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.sql.*. |
26
|
|
| 'if' construct must use '{}'s. |
57
|
|
| Method 'getSelectOptions' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| Parameter table should be final. |
81
|
|
| Parameter idField should be final. |
82
|
|
| Parameter descField should be final. |
83
|
|
| Parameter selectedIndex should be final. |
84
|
|
| Line is longer than 80 characters. |
86
|
|
| Method 'getSelectOptions' is not designed for extension - needs to be abstract, final or empty. |
108
|
|
| Parameter table should be final. |
108
|
|
| Parameter idField should be final. |
109
|
|
| Parameter descField should be final. |
110
|
|
| Parameter condition should be final. |
111
|
|
| Parameter selectedIndex should be final. |
112
|
|
| Line is longer than 80 characters. |
114
|
|
| Method 'getSelectOptions' is not designed for extension - needs to be abstract, final or empty. |
134
|
|
| Parameter table should be final. |
134
|
|
| Parameter idField should be final. |
135
|
|
| Parameter descField should be final. |
136
|
|
| Parameter condition should be final. |
137
|
|
| Parameter orderBy should be final. |
138
|
|
| Parameter selectedIndex should be final. |
139
|
|
| 'if' construct must use '{}'s. |
156
|
|
| 'if' construct must use '{}'s. |
159
|
|
| 'if' construct must use '{}'s. |
176
|
com/pow2/dao/IdGenerator.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.sql.*. |
27
|
|
| 'static' modifier out of order with the JLS suggestions. |
66
|
|
| Name 'qryGetHighValue' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
72
|
|
| Name 'qryUpdateHighValue' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
75
|
|
| Name 'high' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
78
|
|
| Name 'low' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
81
|
|
| Line is longer than 80 characters. |
101
|
|
| 'if' construct must use '{}'s. |
116
|
|
| Method 'setLow' is not designed for extension - needs to be abstract, final or empty. |
128
|
|
| Parameter low should be final. |
128
|
|
| 'low' hides a field. |
128
|
|
| Method 'getLow' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
| Method 'setHigh' is not designed for extension - needs to be abstract, final or empty. |
150
|
|
| Parameter high should be final. |
150
|
|
| 'high' hides a field. |
150
|
|
| Method 'getHigh' is not designed for extension - needs to be abstract, final or empty. |
161
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
173
|
|
| Line is longer than 80 characters. |
180
|
|
| 'high' hides a field. |
235
|
|
| 'if' construct must use '{}'s. |
250
|
|
| Parameter rs should be final. |
292
|
|
| Parameter st should be final. |
293
|
|
| Parameter ps should be final. |
294
|
|
| Expected @param tag for 'ps'. |
294
|
|
| Parameter con should be final. |
295
|
|
| Parameter commit should be final. |
296
|
|
| Expected @param tag for 'commit'. |
296
|
|
| 'if' construct must use '{}'s. |
299
|
com/pow2/dao/JakartaConnectionProvider.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
30
|
|
| Using the '.*' form of import should be avoided - java.sql.*. |
31
|
|
| Name 'dataSource' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| ';' is followed by whitespace. |
94
|
|
| Line is longer than 80 characters. |
98
|
|
| '20' is a magic number. |
103
|
|
| '5' is a magic number. |
104
|
com/pow2/dao/ProtomatterConnectionProvider.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
30
|
|
| Using the '.*' form of import should be avoided - java.sql.*. |
31
|
|
| Line is longer than 80 characters. |
38
|
|
| Line is longer than 80 characters. |
46
|
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| Line is longer than 80 characters. |
73
|
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
| ';' is followed by whitespace. |
104
|
|
| Line is longer than 80 characters. |
108
|
|
| '5' is a magic number. |
115
|
|
| '10' is a magic number. |
118
|
|
| '1000' is a magic number. |
124
|
|
| Line is longer than 80 characters. |
128
|
com/pow2/dao/SimpleConnectionProvider.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
30
|
|
| Using the '.*' form of import should be avoided - java.sql.*. |
31
|
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
| Line is longer than 80 characters. |
79
|
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
91
|
com/pow2/dao/datalist/DataList.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Redundant 'public' modifier. |
42
|
|
| Redundant 'public' modifier. |
50
|
|
| Redundant 'public' modifier. |
61
|
|
| Redundant 'public' modifier. |
70
|
com/pow2/dao/datalist/DataListHandler.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Redundant 'public' modifier. |
45
|
|
| Redundant 'public' modifier. |
56
|
|
| Redundant 'public' modifier. |
66
|
|
| Redundant 'public' modifier. |
74
|
com/pow2/dao/datalist/DataListIterator.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Redundant 'public' modifier. |
44
|
|
| Redundant throws: 'Exception' is unchecked exception. |
44
|
|
| Redundant 'public' modifier. |
54
|
|
| Redundant throws: 'NoSuchElementException' is unchecked exception. |
54
|
com/pow2/dao/datalist/Query.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
38
|
|
| 'static' modifier out of order with the JLS suggestions. |
38
|
|
| Missing a Javadoc comment. |
40
|
|
| Name 'query' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| Name 'condition' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
41
|
|
| Missing a Javadoc comment. |
42
|
|
| Name 'orderBy' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
42
|
|
| Method 'getQuery' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| Method 'setQuery' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Parameter query should be final. |
61
|
|
| 'query' hides a field. |
61
|
|
| Method 'setCondition' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Parameter condition should be final. |
72
|
|
| 'condition' hides a field. |
72
|
|
| Method 'getCondition' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
| Method 'setOrderBy' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Parameter orderBy should be final. |
94
|
|
| 'orderBy' hides a field. |
94
|
|
| Method 'getOrderBy' is not designed for extension - needs to be abstract, final or empty. |
105
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
| 'if' construct must use '{}'s. |
124
|
|
| 'if' construct must use '{}'s. |
127
|
com/pow2/dao/datalist/QueryDAO.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.sql.*. |
26
|
|
| Using the '.*' form of import should be avoided - org.apache.log4j.*. |
28
|
|
| Variable 'cat' must be private and have accessor methods. |
43
|
|
| 'if' construct must use '{}'s. |
64
|
|
| Method 'executeQuery' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Parameter query should be final. |
80
|
|
| Parameter rowMapper should be final. |
81
|
|
| Line is longer than 80 characters. |
100
|
|
| 'catch' is not followed by whitespace. |
104
|
|
| 'if' construct must use '{}'s. |
115
|
com/pow2/dao/datalist/ResultSetDataList.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Redundant 'public' modifier. |
45
|
|
| Redundant 'public' modifier. |
53
|
|
| Redundant 'public' modifier. |
64
|
|
| Redundant 'public' modifier. |
76
|
com/pow2/dao/datalist/ResultSetDataListChunk.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - org.apache.log4j.*. |
28
|
|
| Line is longer than 80 characters. |
41
|
|
| Variable 'cat' must be private and have accessor methods. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Name 'rsDataList' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| Name 'firstElementIndex' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Name 'countOfElements' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
| Missing a Javadoc comment. |
46
|
|
| Name 'currIndex' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
46
|
|
| Parameter rsDataList should be final. |
56
|
|
| 'rsDataList' hides a field. |
56
|
|
| Parameter firstElementIndex should be final. |
57
|
|
| 'firstElementIndex' hides a field. |
57
|
|
| Parameter countOfElements should be final. |
58
|
|
| 'countOfElements' hides a field. |
58
|
|
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Method 'close' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
| Parameter index should be final. |
104
|
|
| Parameter obj should be final. |
104
|
|
| Line is longer than 80 characters. |
113
|
|
| Method 'hasNext' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| Method 'beforeFirst' is not designed for extension - needs to be abstract, final or empty. |
140
|
|
| 'if' construct must use '{}'s. |
142
|
|
| 'else' construct must use '{}'s. |
144
|
|
| Expected an @return tag. |
156
|
|
| Method 'absolute' is not designed for extension - needs to be abstract, final or empty. |
156
|
|
| Parameter index should be final. |
156
|
|
| 'if' construct must use '{}'s. |
158
|
|
| 'if' construct must use '{}'s. |
163
|
|
| Method 'elementExists' is not designed for extension - needs to be abstract, final or empty. |
178
|
|
| Parameter index should be final. |
178
|
|
| 'if' construct must use '{}'s. |
180
|
|
| Method 'isEmpty' is not designed for extension - needs to be abstract, final or empty. |
193
|
|
| 'if' construct must use '{}'s. |
201
|
com/pow2/dao/datalist/ResultSetDataListImpl.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Name 'rowMapper' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| Name 'conn' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Name 'stmt' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
| Missing a Javadoc comment. |
46
|
|
| Name 'rs' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
46
|
|
| Parameter rowMapper should be final. |
57
|
|
| 'rowMapper' hides a field. |
57
|
|
| Parameter conn should be final. |
58
|
|
| 'conn' hides a field. |
58
|
|
| Parameter stmt should be final. |
59
|
|
| 'stmt' hides a field. |
59
|
|
| Parameter rs should be final. |
60
|
|
| 'rs' hides a field. |
60
|
|
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. |
75
|
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
93
|
|
| Parameter index should be final. |
93
|
|
| Parameter item should be final. |
93
|
|
| Line is longer than 80 characters. |
104
|
|
| Line is longer than 80 characters. |
113
|
|
| Method 'hasNext' is not designed for extension - needs to be abstract, final or empty. |
128
|
|
| Method 'beforeFirst' is not designed for extension - needs to be abstract, final or empty. |
141
|
|
| Expected an @return tag. |
154
|
|
| Method 'absolute' is not designed for extension - needs to be abstract, final or empty. |
154
|
|
| Parameter index should be final. |
154
|
|
| Method 'isEmpty' is not designed for extension - needs to be abstract, final or empty. |
166
|
|
| '&&' should be on a new line. |
172
|
|
| '&&' should be on a new line. |
173
|
|
| Method 'elementExists' is not designed for extension - needs to be abstract, final or empty. |
196
|
|
| Parameter index should be final. |
196
|
|
| 'if' construct must use '{}'s. |
204
|
|
| 'if' construct must use '{}'s. |
207
|
|
| 'if' construct must use '{}'s. |
210
|
|
| Method 'close' is not designed for extension - needs to be abstract, final or empty. |
223
|
com/pow2/dao/datalist/ResultSetDataListIterator.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - org.apache.log4j.*. |
29
|
|
| Line is longer than 80 characters. |
42
|
|
| Variable 'cat' must be private and have accessor methods. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Name 'rsDataList' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Name 'currentIndex' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
| Line is longer than 80 characters. |
54
|
|
| Parameter rsDataList should be final. |
54
|
|
| 'rsDataList' hides a field. |
54
|
|
| Method 'hasNext' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Unused @param tag for 'object'. |
84
|
|
| Method 'next' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
| Parameter obj should be final. |
88
|
|
| Expected @param tag for 'obj'. |
88
|
|
| Redundant throws: 'NoSuchElementException' is unchecked exception. |
88
|
com/pow2/dao/datalist/ResultSetRowMapper.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Redundant 'public' modifier. |
45
|
com/pow2/dao/datalist/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/dao/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/dbforms/DbFormsUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Utility classes should not have a public or default constructor. |
42
|
|
| Line is longer than 80 characters. |
56
|
|
| Line is longer than 80 characters. |
60
|
|
| Parameter request should be final. |
60
|
|
| Parameter tableId should be final. |
60
|
|
| Parameter id should be final. |
60
|
|
| Line is longer than 80 characters. |
85
|
|
| Parameter session should be final. |
89
|
|
| Parameter tableId should be final. |
89
|
|
| Parameter id should be final. |
89
|
|
| 'cast' is not followed by whitespace. |
95
|
|
| Line has trailing spaces. |
104
|
|
| Line has trailing spaces. |
105
|
|
| Line has trailing spaces. |
108
|
|
| Line is longer than 80 characters. |
111
|
|
| Line is longer than 80 characters. |
112
|
|
| Parameter map should be final. |
115
|
|
| Parameter field should be final. |
115
|
|
| Parameter defaultValue should be final. |
115
|
|
| Line has trailing spaces. |
118
|
|
| Line has trailing spaces. |
123
|
|
| Line has trailing spaces. |
126
|
|
| Line has trailing spaces. |
127
|
|
| Line has trailing spaces. |
130
|
|
| Parameter map should be final. |
135
|
|
| Parameter field should be final. |
135
|
|
| Line has trailing spaces. |
138
|
|
| 'cast' is not followed by whitespace. |
141
|
|
| Line has trailing spaces. |
143
|
com/pow2/dbforms/Interceptor.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Line is longer than 80 characters. |
39
|
|
| Variable 'cat' must be private and have accessor methods. |
47
|
|
| Missing a Javadoc comment. |
49
|
|
| Line has trailing spaces. |
54
|
|
| Line is longer than 80 characters. |
56
|
|
| Line has trailing spaces. |
58
|
|
| Line has trailing spaces. |
60
|
|
| Line is longer than 80 characters. |
61
|
|
| Line has trailing spaces. |
64
|
|
| Method 'delete' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Parameter con should be final. |
64
|
|
| Line has trailing spaces. |
65
|
|
| Parameter fieldValues should be final. |
65
|
|
| Line has trailing spaces. |
66
|
|
| Parameter tableName should be final. |
66
|
|
| Line has trailing spaces. |
67
|
|
| Parameter keyFieldName should be final. |
67
|
|
| Line has trailing spaces. |
68
|
|
| Parameter isKeyAString should be final. |
68
|
|
| Line has trailing spaces. |
73
|
|
| Line has trailing spaces. |
75
|
|
| Line has trailing spaces. |
77
|
|
| Avoid inline conditionals. |
80
|
|
| Line is longer than 80 characters. |
85
|
|
| Line has trailing spaces. |
89
|
|
| Line has trailing spaces. |
92
|
|
| Line has trailing spaces. |
93
|
|
| Line is longer than 80 characters. |
98
|
|
| Method 'delete' is not designed for extension - needs to be abstract, final or empty. |
103
|
|
| Parameter tableName should be final. |
103
|
|
| Parameter cond should be final. |
104
|
|
| Parameter con should be final. |
105
|
|
| Method 'getNewKey' is not designed for extension - needs to be abstract, final or empty. |
127
|
com/pow2/dbforms/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/resources/ConnectionFactoryInit.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
37
|
|
| Line is longer than 80 characters. |
43
|
|
| Line is longer than 80 characters. |
50
|
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Expected @throws tag for 'ServletException'. |
57
|
|
| 'catch' is not followed by whitespace. |
75
|
com/pow2/resources/InitServlet.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - javax.servlet.http.*. |
29
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
| Variable 'cat' must be private and have accessor methods. |
45
|
|
| Method 'getInitParameterFilePath' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Parameter initParameter should be final. |
58
|
|
| Inner assignments should be avoided. |
64
|
|
| Line is longer than 80 characters. |
66
|
|
| 'if' construct must use '{}'s. |
73
|
|
| Avoid inline conditionals. |
77
|
|
| Parameter fileName should be final. |
92
|
|
| Expected @param tag for 'fileName'. |
92
|
|
| Parameter fileName should be final. |
110
|
com/pow2/resources/Log4jInit.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
58
|
|
| Line is longer than 80 characters. |
59
|
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Expected @throws tag for 'ServletException'. |
70
|
|
| Line is longer than 80 characters. |
77
|
com/pow2/resources/Pow2ToolkitInit.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Redundant import from the same package - com.pow2.resources.Prefs. |
29
|
|
| Line is longer than 80 characters. |
44
|
|
| Line is longer than 80 characters. |
57
|
|
| Line is longer than 80 characters. |
58
|
|
| Line is longer than 80 characters. |
67
|
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| 'catch' is not followed by whitespace. |
90
|
com/pow2/resources/Prefs.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Class Prefs should be declared as final. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| Name 'propertiesFile' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Name 'log4jPropertiesFile' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
| 'if' construct must use '{}'s. |
63
|
|
| Parameter v should be final. |
86
|
|
| Parameter propertiesFile should be final. |
110
|
|
| 'propertiesFile' hides a field. |
110
|
|
| Avoid inline conditionals. |
121
|
|
| Line is longer than 80 characters. |
128
|
|
| 'catch' is not followed by whitespace. |
152
|
com/pow2/resources/PropertiesInit.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
46
|
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Line is longer than 80 characters. |
64
|
|
| Line is longer than 80 characters. |
75
|
|
| Line is longer than 80 characters. |
79
|
|
| Line is longer than 80 characters. |
84
|
|
| Line is longer than 80 characters. |
86
|
|
| Parameter key should be final. |
89
|
|
| 'cast' is not followed by whitespace. |
91
|
|
| Line is longer than 80 characters. |
98
|
|
| Parameter key should be final. |
101
|
|
| Parameter newProperties should be final. |
101
|
com/pow2/resources/PropertyContainer.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Redundant 'public' modifier. |
45
|
|
| Redundant 'public' modifier. |
55
|
|
| Redundant 'public' modifier. |
65
|
|
| Redundant 'public' modifier. |
73
|
|
| Redundant 'public' modifier. |
81
|
com/pow2/resources/PropertyContainerImpl.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
|
| Variable 'cat' must be private and have accessor methods. |
43
|
|
| Name 'properties' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
46
|
|
| Variable 'properties' must be private and have accessor methods. |
46
|
|
| Method 'addProperty' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Parameter value should be final. |
64
|
|
| Parameter token should be final. |
64
|
|
| 'if' construct must use '{}'s. |
66
|
|
| 'if' construct must use '{}'s. |
69
|
|
| Method 'getProperty' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
| Parameter token should be final. |
83
|
|
| Avoid inline conditionals. |
85
|
|
| Method 'getObject' is not designed for extension - needs to be abstract, final or empty. |
96
|
|
| Parameter token should be final. |
96
|
|
| Avoid inline conditionals. |
98
|
|
| Method 'getPropertyKeys' is not designed for extension - needs to be abstract, final or empty. |
107
|
|
| Array brackets at illegal position. |
109
|
|
| Method 'removeProperty' is not designed for extension - needs to be abstract, final or empty. |
134
|
|
| Parameter token should be final. |
134
|
|
| 'if' construct must use '{}'s. |
136
|
com/pow2/resources/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/servlets/HTTPDumpServlet.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.io.*. |
26
|
|
| Using the '.*' form of import should be avoided - javax.servlet.*. |
27
|
|
| Using the '.*' form of import should be avoided - javax.servlet.http.*. |
28
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
|
| Line has trailing spaces. |
60
|
|
| Line has trailing spaces. |
61
|
|
| Method 'doGet' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
| Parameter request should be final. |
65
|
|
| Parameter response should be final. |
66
|
|
| Line contains a tab character. |
69
|
|
| Line has trailing spaces. |
71
|
|
| Line has trailing spaces. |
72
|
|
| Line has trailing spaces. |
76
|
|
| Line has trailing spaces. |
77
|
|
| Method 'doPost' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| Parameter request should be final. |
81
|
|
| Line contains a tab character. |
82
|
|
| Parameter response should be final. |
82
|
|
| Line contains a tab character. |
83
|
|
| Line contains a tab character. |
85
|
|
| Line contains a tab character. |
86
|
|
| Line contains a tab character. |
87
|
com/pow2/servlets/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/structures/tree/BinarySearchTree.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Parameter o should be final. |
27
|
|
| Method 'insert' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
| Parameter o should be final. |
38
|
|
| Line is longer than 80 characters. |
50
|
|
| Line is longer than 80 characters. |
51
|
|
| 'for' construct must use '{}'s. |
53
|
|
| Line is longer than 80 characters. |
53
|
|
| Line is longer than 80 characters. |
54
|
|
| Line is longer than 80 characters. |
55
|
|
| Line is longer than 80 characters. |
56
|
|
| Line is longer than 80 characters. |
57
|
|
| Avoid inline conditionals. |
57
|
|
| Empty statement. |
57
|
|
| Line is longer than 80 characters. |
59
|
|
| '{' should be on a new line. |
59
|
|
| Line is longer than 80 characters. |
60
|
|
| '{' should be on a new line. |
60
|
|
| Line is longer than 80 characters. |
61
|
|
| '{' should be on a new line. |
61
|
|
| Line is longer than 80 characters. |
62
|
|
| '{' should be on a new line. |
62
|
|
| Unused @param tag for 'p'. |
69
|
|
| Method 'visit' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| Parameter n should be final. |
71
|
|
| Expected @param tag for 'n'. |
71
|
com/pow2/structures/tree/BinaryTree.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' Version 1.1'. |
2
|
|
| 'static' modifier out of order with the JLS suggestions. |
46
|
|
| 'static' modifier out of order with the JLS suggestions. |
49
|
|
| 'static' modifier out of order with the JLS suggestions. |
52
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
55
|
|
| Variable 'cat' must be private and have accessor methods. |
55
|
|
| Name 'root' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
58
|
|
| Variable 'root' must be private and have accessor methods. |
58
|
|
| Name 'traverseMode' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
70
|
|
| Variable 'traverseMode' must be private and have accessor methods. |
70
|
|
| Name 'nodeVisitor' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
73
|
|
| Variable 'nodeVisitor' must be private and have accessor methods. |
73
|
|
| Parameter o should be final. |
97
|
|
| Method 'setData' is not designed for extension - needs to be abstract, final or empty. |
112
|
|
| Parameter o should be final. |
112
|
|
| 'if' construct must use '{}'s. |
114
|
|
| Method 'setNodeVisitor' is not designed for extension - needs to be abstract, final or empty. |
125
|
|
| Parameter nodeVisitor should be final. |
125
|
|
| 'nodeVisitor' hides a field. |
125
|
|
| Method 'setRoot' is not designed for extension - needs to be abstract, final or empty. |
136
|
|
| Parameter r should be final. |
136
|
|
| Line is longer than 80 characters. |
146
|
|
| Line is longer than 80 characters. |
147
|
|
| Line is longer than 80 characters. |
148
|
|
| Method 'setTraverseMode' is not designed for extension - needs to be abstract, final or empty. |
153
|
|
| Parameter traverseMode should be final. |
153
|
|
| 'traverseMode' hides a field. |
153
|
|
| Method 'isEmpty' is not designed for extension - needs to be abstract, final or empty. |
167
|
|
| Method 'getData' is not designed for extension - needs to be abstract, final or empty. |
179
|
|
| Avoid inline conditionals. |
181
|
|
| Method 'getNodeVisitor' is not designed for extension - needs to be abstract, final or empty. |
190
|
|
| Method 'getLeft' is not designed for extension - needs to be abstract, final or empty. |
202
|
|
| Avoid inline conditionals. |
204
|
|
| Method 'getRoot' is not designed for extension - needs to be abstract, final or empty. |
213
|
|
| Method 'getRight' is not designed for extension - needs to be abstract, final or empty. |
225
|
|
| Avoid inline conditionals. |
227
|
|
| Method 'getTraverseMode' is not designed for extension - needs to be abstract, final or empty. |
236
|
|
| Method 'insertLeft' is not designed for extension - needs to be abstract, final or empty. |
250
|
|
| Parameter p should be final. |
250
|
|
| Parameter c should be final. |
250
|
|
| 'if' construct must use '{}'s. |
253
|
|
| Method 'insertRight' is not designed for extension - needs to be abstract, final or empty. |
272
|
|
| Parameter p should be final. |
272
|
|
| Parameter c should be final. |
272
|
|
| 'if' construct must use '{}'s. |
275
|
|
| Method 'addLeft' is not designed for extension - needs to be abstract, final or empty. |
294
|
|
| Parameter p should be final. |
294
|
|
| Parameter c should be final. |
294
|
|
| 'if' construct must use '{}'s. |
296
|
|
| 'if' construct must use '{}'s. |
302
|
|
| 'else' construct must use '{}'s. |
304
|
|
| Method 'addRight' is not designed for extension - needs to be abstract, final or empty. |
317
|
|
| Parameter p should be final. |
317
|
|
| Parameter c should be final. |
317
|
|
| 'if' construct must use '{}'s. |
319
|
|
| Method 'move' is not designed for extension - needs to be abstract, final or empty. |
347
|
|
| Parameter p should be final. |
347
|
|
| Parameter c should be final. |
347
|
|
| Parameter isLeft should be final. |
347
|
|
| Line is longer than 80 characters. |
358
|
|
| 'if' construct must use '{}'s. |
362
|
|
| 'else' construct must use '{}'s. |
365
|
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
378
|
|
| Parameter n should be final. |
378
|
|
| Parameter recursive should be final. |
378
|
|
| 'if' construct must use '{}'s. |
380
|
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
404
|
|
| Parameter n should be final. |
404
|
|
| Parameter n should be final. |
417
|
|
| 'if' construct must use '{}'s. |
425
|
|
| 'if' construct must use '{}'s. |
430
|
|
| 'if' construct must use '{}'s. |
433
|
|
| Method 'traverse' is not designed for extension - needs to be abstract, final or empty. |
447
|
|
| switch without "default" clause. |
449
|
|
| Method 'pretrav' is not designed for extension - needs to be abstract, final or empty. |
477
|
|
| Parameter p should be final. |
477
|
|
| 'if' construct must use '{}'s. |
479
|
|
| Method 'intrav' is not designed for extension - needs to be abstract, final or empty. |
497
|
|
| Parameter p should be final. |
497
|
|
| 'if' construct must use '{}'s. |
499
|
|
| Line is longer than 80 characters. |
509
|
|
| Method 'postrav' is not designed for extension - needs to be abstract, final or empty. |
517
|
|
| Parameter p should be final. |
517
|
|
| 'if' construct must use '{}'s. |
519
|
|
| Method 'visit' is not designed for extension - needs to be abstract, final or empty. |
534
|
|
| Parameter n should be final. |
534
|
com/pow2/structures/tree/ItemTree.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Name 'map' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
42
|
|
| Variable 'map' must be private and have accessor methods. |
42
|
|
| Name 'traverseAllNodes' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
|
| Variable 'traverseAllNodes' must be private and have accessor methods. |
48
|
|
| Method 'setTraverseAllNodes' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Parameter traverseAllNodes should be final. |
67
|
|
| 'traverseAllNodes' hides a field. |
67
|
|
| Method 'isTraverseAllNodes' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
| Method 'move' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
| Parameter pId should be final. |
95
|
|
| Parameter id should be final. |
95
|
|
| Parameter left should be final. |
95
|
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
| Parameter n should be final. |
110
|
|
| Method 'getNode' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| Parameter id should be final. |
129
|
|
| Avoid inline conditionals. |
131
|
|
| Method 'pretrav' is not designed for extension - needs to be abstract, final or empty. |
145
|
|
| Parameter p should be final. |
145
|
|
| 'if' construct must use '{}'s. |
147
|
|
| 'if' construct must use '{}'s. |
153
|
|
| Method 'insertLeft' is not designed for extension - needs to be abstract, final or empty. |
168
|
|
| Parameter p should be final. |
168
|
|
| Parameter c should be final. |
168
|
|
| 'if' construct must use '{}'s. |
172
|
|
| Method 'insertRight' is not designed for extension - needs to be abstract, final or empty. |
187
|
|
| Parameter p should be final. |
187
|
|
| Parameter c should be final. |
187
|
|
| 'if' construct must use '{}'s. |
191
|
|
| Method 'addLeft' is not designed for extension - needs to be abstract, final or empty. |
206
|
|
| Parameter p should be final. |
206
|
|
| Parameter c should be final. |
206
|
|
| 'if' construct must use '{}'s. |
210
|
|
| Method 'addRight' is not designed for extension - needs to be abstract, final or empty. |
225
|
|
| Parameter p should be final. |
225
|
|
| Parameter c should be final. |
225
|
|
| 'if' construct must use '{}'s. |
229
|
com/pow2/structures/tree/Node.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Name 'id' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
38
|
|
| Variable 'id' must be private and have accessor methods. |
38
|
|
| Name 'data' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
41
|
|
| Variable 'data' must be private and have accessor methods. |
41
|
|
| Name 'left' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
|
| Variable 'left' must be private and have accessor methods. |
44
|
|
| Name 'right' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
47
|
|
| Variable 'right' must be private and have accessor methods. |
47
|
|
| Name 'parent' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
50
|
|
| Variable 'parent' must be private and have accessor methods. |
50
|
|
| Name 'depth' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
53
|
|
| Variable 'depth' must be private and have accessor methods. |
53
|
|
| Name 'open' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
56
|
|
| Variable 'open' must be private and have accessor methods. |
56
|
|
| Parameter data should be final. |
78
|
|
| 'data' hides a field. |
78
|
|
| Parameter data should be final. |
93
|
|
| 'data' hides a field. |
93
|
|
| Parameter depth should be final. |
93
|
|
| 'depth' hides a field. |
93
|
|
| Unused @param tag for 'd'. |
103
|
|
| Parameter id should be final. |
105
|
|
| 'id' hides a field. |
105
|
|
| Parameter data should be final. |
105
|
|
| 'data' hides a field. |
105
|
|
| Expected @param tag for 'data'. |
105
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
117
|
|
| Parameter v should be final. |
117
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
128
|
|
| Parameter v should be final. |
128
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
| Method 'setLeft' is not designed for extension - needs to be abstract, final or empty. |
150
|
|
| Parameter l should be final. |
150
|
|
| Method 'setRight' is not designed for extension - needs to be abstract, final or empty. |
161
|
|
| Parameter r should be final. |
161
|
|
| Method 'setParent' is not designed for extension - needs to be abstract, final or empty. |
172
|
|
| Parameter p should be final. |
172
|
|
| Method 'setData' is not designed for extension - needs to be abstract, final or empty. |
183
|
|
| Parameter d should be final. |
183
|
|
| Method 'getLeft' is not designed for extension - needs to be abstract, final or empty. |
194
|
|
| Method 'getRight' is not designed for extension - needs to be abstract, final or empty. |
205
|
|
| Method 'getParent' is not designed for extension - needs to be abstract, final or empty. |
216
|
|
| Method 'getData' is not designed for extension - needs to be abstract, final or empty. |
227
|
|
| Method 'isOpen' is not designed for extension - needs to be abstract, final or empty. |
238
|
|
| Method 'setOpening' is not designed for extension - needs to be abstract, final or empty. |
250
|
|
| Parameter open should be final. |
250
|
|
| 'open' hides a field. |
250
|
|
| Method 'getDepth' is not designed for extension - needs to be abstract, final or empty. |
261
|
|
| Method 'setDepth' is not designed for extension - needs to be abstract, final or empty. |
272
|
|
| Parameter depth should be final. |
272
|
|
| 'depth' hides a field. |
272
|
|
| Method 'finalize' is not designed for extension - needs to be abstract, final or empty. |
283
|
com/pow2/structures/tree/NodeVisitorInterface.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Redundant 'public' modifier. |
21
|
com/pow2/structures/tree/StringBufferNodeVisitor.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Name 'buffer' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
23
|
|
| Variable 'buffer' must be private and have accessor methods. |
23
|
|
| Name 'counter' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
26
|
|
| Variable 'counter' must be private and have accessor methods. |
26
|
|
| Method 'getBuffer' is not designed for extension - needs to be abstract, final or empty. |
34
|
|
| Method 'setBuffer' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Parameter buffer should be final. |
45
|
|
| 'buffer' hides a field. |
45
|
|
| Method 'setCounter' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Parameter counter should be final. |
56
|
|
| 'counter' hides a field. |
56
|
|
| Method 'getCounter' is not designed for extension - needs to be abstract, final or empty. |
67
|
com/pow2/structures/tree/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/struts/action/ActionServlet.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Unused import - java.io.IOException. |
24
|
|
| Using the '.*' form of import should be avoided - org.apache.struts.action.*. |
32
|
|
| Redundant import from the same package - com.pow2.struts.action.ToolkitActionMapping. |
34
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
53
|
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Unused @throws tag for 'IOException'. |
84
|
|
| Method 'processActionPerform' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
| Parameter action should be final. |
87
|
|
| Parameter mapping should be final. |
88
|
|
| Parameter formInstance should be final. |
89
|
|
| Parameter request should be final. |
90
|
|
| Parameter response should be final. |
91
|
|
| 'cast' is not followed by whitespace. |
98
|
|
| 'cast' is not followed by whitespace. |
99
|
|
| Line is longer than 80 characters. |
105
|
|
| Line is longer than 80 characters. |
106
|
|
| 'if' construct must use '{}'s. |
108
|
|
| Line contains a tab character. |
108
|
|
| Line is longer than 80 characters. |
109
|
|
| Line contains a tab character. |
109
|
|
| Line has trailing spaces. |
116
|
|
| Line has trailing spaces. |
125
|
com/pow2/struts/action/BaseAction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Using the '.*' form of import should be avoided - org.apache.struts.action.*. |
26
|
|
| 'static' modifier out of order with the JLS suggestions. |
51
|
|
| 'static' modifier out of order with the JLS suggestions. |
54
|
|
| 'static' modifier out of order with the JLS suggestions. |
57
|
|
| 'static' modifier out of order with the JLS suggestions. |
60
|
|
| 'static' modifier out of order with the JLS suggestions. |
63
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
66
|
|
| Variable 'cat' must be private and have accessor methods. |
66
|
|
| Method 'loginForward' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Parameter request should be final. |
76
|
|
| Parameter mapping should be final. |
77
|
|
| Line is longer than 80 characters. |
91
|
|
| Method 'loginForward' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Parameter request should be final. |
94
|
|
| Parameter mapping should be final. |
95
|
|
| Parameter errors should be final. |
96
|
|
| Parameter errorKey should be final. |
97
|
|
| Line is longer than 80 characters. |
111
|
|
| Method 'failureForward' is not designed for extension - needs to be abstract, final or empty. |
114
|
|
| Parameter request should be final. |
114
|
|
| Parameter mapping should be final. |
115
|
|
| Parameter errors should be final. |
116
|
|
| Parameter errorKey should be final. |
117
|
|
| Method 'invalidSessionForward' is not designed for extension - needs to be abstract, final or empty. |
134
|
|
| Parameter request should be final. |
134
|
|
| Parameter mapping should be final. |
135
|
|
| Parameter errors should be final. |
136
|
|
| Line is longer than 80 characters. |
138
|
|
| Line is longer than 80 characters. |
143
|
|
| Line is longer than 80 characters. |
151
|
|
| Method 'getForward' is not designed for extension - needs to be abstract, final or empty. |
154
|
|
| Parameter request should be final. |
154
|
|
| Parameter mapping should be final. |
155
|
|
| Parameter errors should be final. |
156
|
|
| Parameter forward should be final. |
157
|
|
| Parameter errorKey should be final. |
158
|
|
| 'if' construct must use '{}'s. |
168
|
|
| Line is longer than 80 characters. |
169
|
|
| Expected an @return tag. |
180
|
|
| Method 'isFailureForward' is not designed for extension - needs to be abstract, final or empty. |
180
|
|
| Parameter forward should be final. |
180
|
|
| Unused @param tag for 'HttpServletRequest'. |
193
|
|
| Method 'validateSession' is not designed for extension - needs to be abstract, final or empty. |
197
|
|
| Parameter request should be final. |
197
|
|
| Expected @param tag for 'request'. |
197
|
com/pow2/struts/action/DispatcherAction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Line is longer than 80 characters. |
44
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| Parameter mapping should be final. |
68
|
|
| Parameter form should be final. |
69
|
|
| Parameter request should be final. |
70
|
|
| Parameter response should be final. |
71
|
|
| Expected @throws tag for 'java.io.IOException'. |
73
|
|
| Expected @throws tag for 'javax.servlet.ServletException'. |
74
|
|
| Line is longer than 80 characters. |
80
|
|
| Line is longer than 80 characters. |
81
|
|
| 'if' construct must use '{}'s. |
88
|
|
| 'if' construct must use '{}'s. |
94
|
|
| Line is longer than 80 characters. |
97
|
|
| 'if' construct must use '{}'s. |
108
|
|
| 'if' construct must use '{}'s. |
112
|
|
| 'if' construct must use '{}'s. |
116
|
|
| Line is longer than 80 characters. |
117
|
com/pow2/struts/action/ToolkitActionMapping.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Missing a Javadoc comment. |
35
|
|
| Name 'validateSession' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
35
|
|
| Line has trailing spaces. |
37
|
|
| Method 'isValidateSession' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
| Method 'setValidateSession' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Parameter validateSession should be final. |
54
|
|
| 'validateSession' hides a field. |
54
|
com/pow2/struts/action/UserValidationAction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Line is longer than 80 characters. |
31
|
|
| Line is longer than 80 characters. |
32
|
|
| Unused @param tag for 'HttpServletRequest'. |
45
|
|
| Method 'validateSession' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Parameter request should be final. |
48
|
|
| Expected @param tag for 'request'. |
48
|
com/pow2/struts/action/UserValidationDispatcherAction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Line is longer than 80 characters. |
30
|
|
| Line is longer than 80 characters. |
31
|
|
| Unused @param tag for 'HttpServletRequest'. |
44
|
|
| Method 'validateSession' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Parameter request should be final. |
47
|
|
| Expected @param tag for 'request'. |
47
|
com/pow2/struts/action/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/struts/actions/LoginAction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Line is longer than 80 characters. |
55
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Parameter mapping should be final. |
94
|
|
| Parameter form should be final. |
95
|
|
| Parameter request should be final. |
96
|
|
| Parameter response should be final. |
97
|
|
| Expected @throws tag for 'java.io.IOException'. |
99
|
|
| Expected @throws tag for 'javax.servlet.ServletException'. |
100
|
|
| 'catch' is not followed by whitespace. |
114
|
|
| Line is longer than 80 characters. |
117
|
|
| 'if' construct must use '{}'s. |
122
|
|
| Inner assignments should be avoided. |
134
|
|
| '?' should be on a new line. |
134
|
|
| Avoid inline conditionals. |
134
|
|
| ':' should be on a new line. |
135
|
|
| 'if' construct must use '{}'s. |
144
|
|
| 'if' construct must use '{}'s. |
148
|
|
| Line is longer than 80 characters. |
149
|
com/pow2/struts/actions/LogoutAction.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Using the '.*' form of import should be avoided - javax.servlet.http.*. |
23
|
|
| Using the '.*' form of import should be avoided - org.apache.struts.action.*. |
25
|
|
| Using the '.*' form of import should be avoided - com.pow2.struts.action.*. |
27
|
|
| Using the '.*' form of import should be avoided - com.pow2.user.*. |
28
|
|
| Line is longer than 80 characters. |
54
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Parameter mapping should be final. |
67
|
|
| Parameter form should be final. |
68
|
|
| Parameter request should be final. |
69
|
|
| Parameter response should be final. |
70
|
|
| Expected @throws tag for 'java.io.IOException'. |
72
|
|
| Expected @throws tag for 'javax.servlet.ServletException'. |
73
|
|
| 'if' construct must use '{}'s. |
85
|
|
| Line is longer than 80 characters. |
86
|
|
| Avoid inline conditionals. |
88
|
com/pow2/struts/actions/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/struts/forms/FormsUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Utility classes should not have a public or default constructor. |
37
|
|
| Line is longer than 80 characters. |
48
|
|
| Line is longer than 80 characters. |
49
|
|
| Parameter target should be final. |
52
|
|
| Parameter source should be final. |
52
|
|
| Line is longer than 80 characters. |
67
|
|
| Line is longer than 80 characters. |
68
|
|
| Parameter target should be final. |
71
|
|
| Parameter source should be final. |
71
|
|
| Line is longer than 80 characters. |
86
|
|
| Line is longer than 80 characters. |
87
|
|
| Parameter target should be final. |
91
|
|
| Parameter sourceMap should be final. |
91
|
com/pow2/struts/forms/LoginForm.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Missing a Javadoc comment. |
45
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
| Missing a Javadoc comment. |
46
|
|
| Name 'login' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
46
|
|
| Missing a Javadoc comment. |
47
|
|
| Name 'passwd' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
47
|
|
| Method 'getLogin' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
| Method 'getPasswd' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Method 'setLogin' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
| Parameter v should be final. |
87
|
|
| Method 'setPasswd' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
| Parameter v should be final. |
98
|
|
| Line is longer than 80 characters. |
122
|
|
| Method 'validate' is not designed for extension - needs to be abstract, final or empty. |
122
|
|
| Parameter mapping should be final. |
122
|
|
| Parameter request should be final. |
122
|
|
| Line is longer than 80 characters. |
128
|
|
| Line is longer than 80 characters. |
134
|
|
| Avoid inline conditionals. |
138
|
|
| Method 'clear' is not designed for extension - needs to be abstract, final or empty. |
145
|
com/pow2/struts/forms/RegistrationForm.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' Version 1.1'. |
2
|
|
| Using the '.*' form of import should be avoided - javax.servlet.http.*. |
25
|
|
| Using the '.*' form of import should be avoided - org.apache.struts.action.*. |
28
|
|
| Missing a Javadoc comment. |
45
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Name 'city' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
47
|
|
| Missing a Javadoc comment. |
48
|
|
| Name 'email' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
|
| Missing a Javadoc comment. |
49
|
|
| Name 'fax' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
|
| Missing a Javadoc comment. |
50
|
|
| Name 'firstName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
50
|
|
| Missing a Javadoc comment. |
51
|
|
| Name 'id' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
51
|
|
| Missing a Javadoc comment. |
52
|
|
| Name 'lastName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
52
|
|
| Missing a Javadoc comment. |
53
|
|
| Name 'login' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
53
|
|
| Missing a Javadoc comment. |
54
|
|
| Name 'mobile' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
54
|
|
| Missing a Javadoc comment. |
55
|
|
| Name 'passwd' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
55
|
|
| Missing a Javadoc comment. |
56
|
|
| Name 'passwdConfirm' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
56
|
|
| Missing a Javadoc comment. |
57
|
|
| Name 'phone' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
57
|
|
| Missing a Javadoc comment. |
58
|
|
| Name 'state' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
58
|
|
| Missing a Javadoc comment. |
59
|
|
| Name 'street' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
59
|
|
| Missing a Javadoc comment. |
60
|
|
| Name 'zipCode' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
60
|
|
| Method 'getCity' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
| Method 'getEmail' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
| Method 'getFax' is not designed for extension - needs to be abstract, final or empty. |
96
|
|
| Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. |
107
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
118
|
|
| Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| Method 'getLogin' is not designed for extension - needs to be abstract, final or empty. |
140
|
|
| Method 'getMobile' is not designed for extension - needs to be abstract, final or empty. |
151
|
|
| Method 'getPasswd' is not designed for extension - needs to be abstract, final or empty. |
162
|
|
| Method 'getPasswdConfirm' is not designed for extension - needs to be abstract, final or empty. |
173
|
|
| Method 'getPhone' is not designed for extension - needs to be abstract, final or empty. |
184
|
|
| Method 'getState' is not designed for extension - needs to be abstract, final or empty. |
195
|
|
| Method 'getStreet' is not designed for extension - needs to be abstract, final or empty. |
206
|
|
| Method 'getZipCode' is not designed for extension - needs to be abstract, final or empty. |
217
|
|
| Line is longer than 80 characters. |
225
|
|
| Line is longer than 80 characters. |
227
|
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
233
|
|
| Parameter mapping should be final. |
233
|
|
| Parameter request should be final. |
233
|
|
| Method 'setCity' is not designed for extension - needs to be abstract, final or empty. |
264
|
|
| Parameter v should be final. |
264
|
|
| Method 'setEmail' is not designed for extension - needs to be abstract, final or empty. |
275
|
|
| Parameter v should be final. |
275
|
|
| Method 'setFax' is not designed for extension - needs to be abstract, final or empty. |
286
|
|
| Parameter v should be final. |
286
|
|
| Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. |
297
|
|
| Parameter v should be final. |
297
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
308
|
|
| Parameter id should be final. |
308
|
|
| 'id' hides a field. |
308
|
|
| Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. |
319
|
|
| Parameter v should be final. |
319
|
|
| Method 'setLogin' is not designed for extension - needs to be abstract, final or empty. |
330
|
|
| Parameter v should be final. |
330
|
|
| Method 'setMobile' is not designed for extension - needs to be abstract, final or empty. |
341
|
|
| Parameter v should be final. |
341
|
|
| Method 'setPasswd' is not designed for extension - needs to be abstract, final or empty. |
352
|
|
| Parameter v should be final. |
352
|
|
| Method 'setPasswdConfirm' is not designed for extension - needs to be abstract, final or empty. |
363
|
|
| Parameter v should be final. |
363
|
|
| Method 'setPhone' is not designed for extension - needs to be abstract, final or empty. |
374
|
|
| Parameter v should be final. |
374
|
|
| Method 'setState' is not designed for extension - needs to be abstract, final or empty. |
385
|
|
| Parameter v should be final. |
385
|
|
| Method 'setStreet' is not designed for extension - needs to be abstract, final or empty. |
396
|
|
| Parameter v should be final. |
396
|
|
| Method 'setZipCode' is not designed for extension - needs to be abstract, final or empty. |
407
|
|
| Parameter v should be final. |
407
|
|
| Line is longer than 80 characters. |
421
|
|
| Method 'validate' is not designed for extension - needs to be abstract, final or empty. |
421
|
|
| Parameter mapping should be final. |
421
|
|
| Parameter request should be final. |
421
|
|
| 'if' construct must use '{}'s. |
425
|
|
| Line is longer than 80 characters. |
426
|
|
| 'if' construct must use '{}'s. |
428
|
|
| Line is longer than 80 characters. |
429
|
|
| 'if' construct must use '{}'s. |
431
|
|
| Line is longer than 80 characters. |
432
|
|
| Line is longer than 80 characters. |
441
|
|
| Avoid inline conditionals. |
450
|
com/pow2/struts/forms/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/struts/util/MessageUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Utility classes should not have a public or default constructor. |
44
|
|
| Line is longer than 80 characters. |
55
|
|
| Line is longer than 80 characters. |
56
|
|
| Line is longer than 80 characters. |
57
|
|
| Line is longer than 80 characters. |
58
|
|
| Parameter pageContext should be final. |
68
|
|
| Parameter messageKey should be final. |
68
|
|
| Line is longer than 80 characters. |
75
|
|
| 'catch' is not followed by whitespace. |
79
|
|
| Line is longer than 80 characters. |
81
|
|
| Line is longer than 80 characters. |
93
|
|
| Line is longer than 80 characters. |
94
|
|
| Line is longer than 80 characters. |
95
|
|
| Line is longer than 80 characters. |
96
|
|
| Line is longer than 80 characters. |
97
|
|
| Parameter pageContext should be final. |
108
|
|
| Parameter messageKey should be final. |
109
|
|
| Parameter args should be final. |
110
|
|
| 'catch' is not followed by whitespace. |
122
|
|
| Line is longer than 80 characters. |
124
|
|
| Parameter pageContext should be final. |
138
|
|
| Parameter jspException should be final. |
139
|
|
| Line is longer than 80 characters. |
144
|
|
| 'cast' is not followed by whitespace. |
149
|
|
| Line is longer than 80 characters. |
156
|
|
| 'if' construct must use '{}'s. |
158
|
|
| 'cast' is not followed by whitespace. |
158
|
|
| Line is longer than 80 characters. |
159
|
com/pow2/struts/util/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/texen/ant/FileBean.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - com.pow2.util.*. |
27
|
|
| Missing a Javadoc comment. |
38
|
|
| Name 'fileDirectory' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
38
|
|
| Missing a Javadoc comment. |
39
|
|
| Name 'fileName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Name 'fileContent' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
40
|
|
| Method 'setFileDirectory' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Parameter fileDirectory should be final. |
56
|
|
| 'fileDirectory' hides a field. |
56
|
|
| Method 'getFileDirectory' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Method 'getFileName' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
| Method 'setFileName' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
| Parameter fileName should be final. |
89
|
|
| 'fileName' hides a field. |
89
|
|
| Method 'setFileContent' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
| Parameter fileContent should be final. |
100
|
|
| 'fileContent' hides a field. |
100
|
|
| Method 'getFileContent' is not designed for extension - needs to be abstract, final or empty. |
111
|
|
| Method 'getFileContent' is not designed for extension - needs to be abstract, final or empty. |
124
|
|
| Parameter fileName should be final. |
124
|
|
| 'fileName' hides a field. |
124
|
|
| 'if' construct must use '{}'s. |
129
|
|
| 'catch' is not followed by whitespace. |
138
|
com/pow2/texen/ant/SimplePreprocessorTask.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - org.apache.velocity.context.*. |
27
|
|
| Method 'initControlContext' is not designed for extension - needs to be abstract, final or empty. |
62
|
com/pow2/texen/ant/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/user/Address.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line has trailing spaces. |
6
|
|
| Line has trailing spaces. |
11
|
|
| Line has trailing spaces. |
13
|
|
| Line has trailing spaces. |
14
|
|
| Line has trailing spaces. |
17
|
|
| Line has trailing spaces. |
18
|
|
| Line has trailing spaces. |
20
|
|
| Line has trailing spaces. |
21
|
|
| Variable 'cat' must be private and have accessor methods. |
41
|
|
| Name 'user' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
|
| Variable 'user' must be private and have accessor methods. |
44
|
|
| Name 'country' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
47
|
|
| Variable 'country' must be private and have accessor methods. |
47
|
|
| Name 'state' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
50
|
|
| Variable 'state' must be private and have accessor methods. |
50
|
|
| Name 'city' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
53
|
|
| Variable 'city' must be private and have accessor methods. |
53
|
|
| Name 'zipCode' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
56
|
|
| Variable 'zipCode' must be private and have accessor methods. |
56
|
|
| Name 'street' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
59
|
|
| Variable 'street' must be private and have accessor methods. |
59
|
|
| Parameter newUser should be final. |
67
|
|
| Expected @param tag for 'newUser'. |
67
|
|
| Method 'setUser' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
| Parameter newUser should be final. |
78
|
|
| Method 'setCountry' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
| Parameter newCountry should be final. |
89
|
|
| Method 'setState' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
| Parameter newState should be final. |
100
|
|
| Method 'setCity' is not designed for extension - needs to be abstract, final or empty. |
111
|
|
| Parameter newCity should be final. |
111
|
|
| Method 'setZipCode' is not designed for extension - needs to be abstract, final or empty. |
122
|
|
| Parameter newZipCode should be final. |
122
|
|
| Method 'setStreet' is not designed for extension - needs to be abstract, final or empty. |
133
|
|
| Parameter newStreet should be final. |
133
|
|
| Method 'getUser' is not designed for extension - needs to be abstract, final or empty. |
144
|
|
| Method 'getCountry' is not designed for extension - needs to be abstract, final or empty. |
155
|
|
| Method 'getState' is not designed for extension - needs to be abstract, final or empty. |
166
|
|
| Method 'getCity' is not designed for extension - needs to be abstract, final or empty. |
177
|
|
| Method 'getZipCode' is not designed for extension - needs to be abstract, final or empty. |
188
|
|
| Method 'getStreet' is not designed for extension - needs to be abstract, final or empty. |
199
|
com/pow2/user/User.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' Version 1.1'. |
2
|
|
| Using the '.*' form of import should be avoided - com.pow2.user.dao.*. |
29
|
|
| Name 'USER_ID_NOTPERSISTED' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
47
|
|
| Variable 'USER_ID_NOTPERSISTED' must be private and have accessor methods. |
47
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
50
|
|
| Variable 'cat' must be private and have accessor methods. |
50
|
|
| Name 'authenticated' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
53
|
|
| Variable 'authenticated' must be private and have accessor methods. |
53
|
|
| Name 'city' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
56
|
|
| Variable 'city' must be private and have accessor methods. |
56
|
|
| Name 'dao' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
59
|
|
| Variable 'dao' must be private and have accessor methods. |
59
|
|
| Name 'email' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
62
|
|
| Variable 'email' must be private and have accessor methods. |
62
|
|
| Name 'fax' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
65
|
|
| Variable 'fax' must be private and have accessor methods. |
65
|
|
| Name 'firstName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
68
|
|
| Variable 'firstName' must be private and have accessor methods. |
68
|
|
| Name 'id' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
71
|
|
| Variable 'id' must be private and have accessor methods. |
71
|
|
| Name 'lastName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
74
|
|
| Variable 'lastName' must be private and have accessor methods. |
74
|
|
| Name 'login' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
77
|
|
| Variable 'login' must be private and have accessor methods. |
77
|
|
| Name 'mobile' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
80
|
|
| Variable 'mobile' must be private and have accessor methods. |
80
|
|
| Name 'passwd' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
83
|
|
| Variable 'passwd' must be private and have accessor methods. |
83
|
|
| Name 'phone' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
86
|
|
| Variable 'phone' must be private and have accessor methods. |
86
|
|
| Name 'state' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
89
|
|
| Variable 'state' must be private and have accessor methods. |
89
|
|
| Name 'street' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
92
|
|
| Variable 'street' must be private and have accessor methods. |
92
|
|
| Name 'zipCode' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
95
|
|
| Variable 'zipCode' must be private and have accessor methods. |
95
|
|
| Line is longer than 80 characters. |
109
|
|
| Parameter login should be final. |
119
|
|
| 'login' hides a field. |
119
|
|
| Parameter passwd should be final. |
119
|
|
| 'passwd' hides a field. |
119
|
|
| Method 'getCity' is not designed for extension - needs to be abstract, final or empty. |
135
|
|
| Method 'getEmail' is not designed for extension - needs to be abstract, final or empty. |
146
|
|
| Method 'getFax' is not designed for extension - needs to be abstract, final or empty. |
157
|
|
| Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. |
168
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
179
|
|
| Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. |
190
|
|
| Method 'getLogin' is not designed for extension - needs to be abstract, final or empty. |
201
|
|
| Method 'getMobile' is not designed for extension - needs to be abstract, final or empty. |
212
|
|
| Method 'getPasswd' is not designed for extension - needs to be abstract, final or empty. |
223
|
|
| Method 'getPhone' is not designed for extension - needs to be abstract, final or empty. |
234
|
|
| Line is longer than 80 characters. |
246
|
|
| Method 'getProfile' is not designed for extension - needs to be abstract, final or empty. |
250
|
|
| Method 'getState' is not designed for extension - needs to be abstract, final or empty. |
269
|
|
| Method 'getStreet' is not designed for extension - needs to be abstract, final or empty. |
281
|
|
| Method 'getZipCode' is not designed for extension - needs to be abstract, final or empty. |
292
|
|
| Method 'isAuthenticated' is not designed for extension - needs to be abstract, final or empty. |
303
|
|
| Method 'setAuthentication' is not designed for extension - needs to be abstract, final or empty. |
319
|
|
| Parameter v should be final. |
319
|
|
| Method 'setCity' is not designed for extension - needs to be abstract, final or empty. |
330
|
|
| Parameter city should be final. |
330
|
|
| 'city' hides a field. |
330
|
|
| Method 'setEmail' is not designed for extension - needs to be abstract, final or empty. |
341
|
|
| Parameter v should be final. |
341
|
|
| Method 'setFax' is not designed for extension - needs to be abstract, final or empty. |
352
|
|
| Parameter fax should be final. |
352
|
|
| 'fax' hides a field. |
352
|
|
| Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. |
363
|
|
| Parameter v should be final. |
363
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
374
|
|
| Parameter v should be final. |
374
|
|
| Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. |
385
|
|
| Parameter v should be final. |
385
|
|
| Method 'setLogin' is not designed for extension - needs to be abstract, final or empty. |
396
|
|
| Parameter v should be final. |
396
|
|
| Method 'setMobile' is not designed for extension - needs to be abstract, final or empty. |
407
|
|
| Parameter mobile should be final. |
407
|
|
| 'mobile' hides a field. |
407
|
|
| Method 'setPasswd' is not designed for extension - needs to be abstract, final or empty. |
418
|
|
| Parameter v should be final. |
418
|
|
| Method 'setPhone' is not designed for extension - needs to be abstract, final or empty. |
429
|
|
| Parameter phone should be final. |
429
|
|
| 'phone' hides a field. |
429
|
|
| Method 'setState' is not designed for extension - needs to be abstract, final or empty. |
441
|
|
| Parameter state should be final. |
441
|
|
| 'state' hides a field. |
441
|
|
| Method 'setStreet' is not designed for extension - needs to be abstract, final or empty. |
452
|
|
| Parameter street should be final. |
452
|
|
| 'street' hides a field. |
452
|
|
| Method 'setZipCode' is not designed for extension - needs to be abstract, final or empty. |
463
|
|
| Parameter zipCode should be final. |
463
|
|
| 'zipCode' hides a field. |
463
|
com/pow2/user/UserManager.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Class UserManager should be declared as final. |
50
|
|
| 'static' modifier out of order with the JLS suggestions. |
53
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
56
|
|
| 'if' construct must use '{}'s. |
77
|
|
| Parameter request should be final. |
91
|
|
| 'cast' is not followed by whitespace. |
98
|
|
| Line has trailing spaces. |
99
|
|
| Line has trailing spaces. |
100
|
|
| Line is longer than 80 characters. |
103
|
|
| Line has trailing spaces. |
112
|
|
| Parameter login should be final. |
133
|
|
| Parameter passwd should be final. |
133
|
|
| Expected @throws tag for 'Exception'. |
133
|
|
| Line is longer than 80 characters. |
142
|
|
| Line is longer than 80 characters. |
148
|
|
| Line is longer than 80 characters. |
161
|
|
| Line is longer than 80 characters. |
165
|
|
| Parameter request should be final. |
165
|
|
| Parameter authenticate should be final. |
165
|
|
| Expected @throws tag for 'Exception'. |
165
|
|
| 'if' construct must use '{}'s. |
172
|
|
| Parameter request should be final. |
199
|
|
| 'if' construct must use '{}'s. |
203
|
|
| Parameter id should be final. |
215
|
|
| 'catch' is not followed by whitespace. |
223
|
|
| Parameter request should be final. |
241
|
|
| Line is longer than 80 characters. |
256
|
|
| Line is longer than 80 characters. |
260
|
|
| Parameter request should be final. |
260
|
|
| Parameter userClass should be final. |
260
|
|
| 'catch' is not followed by whitespace. |
272
|
|
| Line is longer than 80 characters. |
274
|
|
| Line is longer than 80 characters. |
281
|
|
| 'cast' is not followed by whitespace. |
286
|
|
| Parameter request should be final. |
299
|
|
| Parameter user should be final. |
299
|
|
| Parameter user should be final. |
317
|
|
| Parameter user should be final. |
337
|
|
| Expected @param tag for 'user'. |
337
|
|
| Parameter form should be final. |
337
|
|
| Expected @param tag for 'form'. |
337
|
|
| Parameter update should be final. |
337
|
|
| Expected @param tag for 'update'. |
337
|
|
| Parameter request should be final. |
377
|
|
| '&&' should be on a new line. |
379
|
|
| Avoid inline conditionals. |
380
|
com/pow2/user/dao/DBUserDAO.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.sql.*. |
30
|
|
| 'if' construct must use '{}'s. |
70
|
|
| Method 'getProviderType' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
| Unused @param tag for 'dao'. |
95
|
|
| Line is longer than 80 characters. |
98
|
|
| Method 'getUser' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
| Parameter login should be final. |
102
|
|
| Parameter passwd should be final. |
102
|
|
| Method 'getUser' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
| Parameter user should be final. |
119
|
|
| 'if' construct must use '{}'s. |
174
|
|
| Method 'setUser' is not designed for extension - needs to be abstract, final or empty. |
188
|
|
| Parameter user should be final. |
188
|
|
| Line is longer than 80 characters. |
195
|
|
| Line is longer than 80 characters. |
196
|
|
| '15' is a magic number. |
210
|
|
| '14' is a magic number. |
219
|
|
| Method 'deleteUser' is not designed for extension - needs to be abstract, final or empty. |
237
|
|
| Parameter id should be final. |
237
|
|
| Line is longer than 80 characters. |
248
|
|
| Method 'loginExists' is not designed for extension - needs to be abstract, final or empty. |
252
|
|
| Parameter user should be final. |
252
|
|
| Line is longer than 80 characters. |
263
|
|
| Method 'loginExists' is not designed for extension - needs to be abstract, final or empty. |
267
|
|
| Parameter login should be final. |
267
|
|
| 'if' construct must use '{}'s. |
269
|
|
| Line is longer than 80 characters. |
284
|
|
| Parameter user should be final. |
288
|
|
| Parameter ps should be final. |
288
|
|
| Parameter i should be final. |
288
|
|
| Expected @throws tag for 'SQLException'. |
289
|
|
| Line is longer than 80 characters. |
303
|
com/pow2/user/dao/LDAPUserDAO.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
com/pow2/user/dao/LDAPUserDAO.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - com.novell.ldap.*. |
5
|
|
| Class LDAPUserDAO should be declared as final. |
18
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
21
|
|
| Variable 'cat' must be private and have accessor methods. |
21
|
|
| 'static' modifier out of order with the JLS suggestions. |
27
|
|
| 'static' modifier out of order with the JLS suggestions. |
30
|
|
| 'static' modifier out of order with the JLS suggestions. |
33
|
|
| 'static' modifier out of order with the JLS suggestions. |
36
|
|
| 'static' modifier out of order with the JLS suggestions. |
39
|
|
| 'static' modifier out of order with the JLS suggestions. |
42
|
|
| 'static' modifier out of order with the JLS suggestions. |
45
|
|
| 'static' modifier out of order with the JLS suggestions. |
48
|
|
| 'static' modifier out of order with the JLS suggestions. |
51
|
|
| 'static' modifier out of order with the JLS suggestions. |
54
|
|
| 'static' modifier out of order with the JLS suggestions. |
57
|
|
| Unused @param tag for 'dao'. |
104
|
|
| Line is longer than 80 characters. |
107
|
|
| Parameter login should be final. |
111
|
|
| Parameter passwd should be final. |
111
|
|
| Unused @param tag for 'passwd'. |
122
|
|
| Line is longer than 80 characters. |
123
|
|
| Unused Javadoc tag. |
123
|
|
| Parameter user should be final. |
127
|
|
| Expected @param tag for 'user'. |
127
|
|
| 'if' construct must use '{}'s. |
155
|
|
| 'if' construct must use '{}'s. |
158
|
|
| Line is longer than 80 characters. |
159
|
|
| Line is longer than 80 characters. |
178
|
|
| Line is longer than 80 characters. |
179
|
|
| Line is longer than 80 characters. |
180
|
|
| Line is longer than 80 characters. |
181
|
|
| Line is longer than 80 characters. |
182
|
|
| Line is longer than 80 characters. |
183
|
|
| 'if' construct must use '{}'s. |
191
|
|
| 'if' construct must use '{}'s. |
195
|
|
| Parameter user should be final. |
209
|
|
| Parameter id should be final. |
221
|
|
| Line is longer than 80 characters. |
232
|
|
| Parameter user should be final. |
236
|
|
| Line is longer than 80 characters. |
247
|
|
| Parameter login should be final. |
251
|
|
| 'if' construct must use '{}'s. |
253
|
|
| 'if' construct must use '{}'s. |
275
|
|
| Expected an @return tag. |
299
|
|
| Expected @throws tag for 'Exception'. |
299
|
|
| Line is longer than 80 characters. |
308
|
|
| Parameter con should be final. |
319
|
|
| Expected @param tag for 'con'. |
319
|
|
| Expected @throws tag for 'Exception'. |
319
|
com/pow2/user/dao/UserDAO.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Redundant 'public' modifier. |
18
|
|
| Line is longer than 80 characters. |
27
|
|
| Redundant 'public' modifier. |
31
|
|
| Redundant 'public' modifier. |
45
|
|
| Redundant 'public' modifier. |
57
|
|
| Redundant 'public' modifier. |
66
|
|
| Line is longer than 80 characters. |
74
|
|
| Redundant 'public' modifier. |
78
|
|
| Line is longer than 80 characters. |
86
|
|
| Redundant 'public' modifier. |
90
|
com/pow2/user/dao/UserDAOFactory.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Class UserDAOFactory should be declared as final. |
15
|
|
| 'static' modifier out of order with the JLS suggestions. |
18
|
|
| 'static' modifier out of order with the JLS suggestions. |
21
|
|
| 'static' modifier out of order with the JLS suggestions. |
24
|
|
| Name 'defaultProvider' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
30
|
|
| 'static' modifier out of order with the JLS suggestions. |
33
|
|
| 'static' modifier out of order with the JLS suggestions. |
36
|
|
| Name 'cat' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
39
|
|
| 'if' construct must use '{}'s. |
49
|
|
| 'if' construct must use '{}'s. |
52
|
|
| 'if' construct must use '{}'s. |
55
|
|
| 'if' construct must use '{}'s. |
69
|
|
| Expected an @return tag. |
80
|
|
| Parameter provider should be final. |
100
|
|
| switch without "default" clause. |
102
|
com/pow2/user/dao/UserDAOUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Utility classes should not have a public or default constructor. |
35
|
|
| Line is longer than 80 characters. |
47
|
|
| Line is longer than 80 characters. |
51
|
|
| Parameter dao should be final. |
51
|
|
| Parameter login should be final. |
51
|
|
| Parameter passwd should be final. |
51
|
|
| Avoid inline conditionals. |
60
|
|
| Parameter user should be final. |
70
|
|
| 'if' construct must use '{}'s. |
72
|
|
| 'return' is not followed by whitespace. |
73
|
|
| '?' should be on a new line. |
77
|
|
| Avoid inline conditionals. |
77
|
|
| ':' should be on a new line. |
81
|
com/pow2/user/dao/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/user/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/pow2/util/DateUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.text.*. |
26
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
27
|
|
| Utility classes should not have a public or default constructor. |
37
|
|
| Expected an @return tag. |
50
|
|
| Parameter dateFormat should be final. |
50
|
|
| Parameter date should be final. |
67
|
|
| Parameter dateFormat should be final. |
67
|
|
| Parameter sDate should be final. |
85
|
|
| Parameter dateFormat should be final. |
85
|
|
| Parameter startDate should be final. |
102
|
|
| Parameter dateFormat should be final. |
102
|
|
| Parameter days should be final. |
102
|
|
| Parameter startDate should be final. |
115
|
|
| Parameter days should be final. |
115
|
|
| Parameter d should be final. |
134
|
|
| Parameter d1 should be final. |
134
|
|
| Parameter d2 should be final. |
134
|
|
| '&&' should be on a new line. |
136
|
com/pow2/util/FileUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.io.*. |
26
|
|
| Redundant import from the java.lang package - java.lang.StringBuffer. |
27
|
|
| Utility classes should not have a public or default constructor. |
40
|
|
| 'static' modifier out of order with the JLS suggestions. |
43
|
|
| Name 'cat' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
43
|
|
| Line is longer than 80 characters. |
47
|
|
| Parameter file should be final. |
54
|
|
| 'while' construct must use '{}'s. |
64
|
|
| 'if' construct must use '{}'s. |
71
|
|
| Line is longer than 80 characters. |
78
|
|
| Parameter propsFile should be final. |
86
|
|
| Line is longer than 80 characters. |
93
|
|
| Line is longer than 80 characters. |
102
|
|
| Parameter propsFile should be final. |
102
|
|
| Parameter addToSystemProps should be final. |
102
|
|
| Line is longer than 80 characters. |
110
|
|
| Avoid inline conditionals. |
110
|
|
| 'if' construct must use '{}'s. |
116
|
com/pow2/util/LabelValueBean.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
35
|
|
| Name 'label' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
35
|
|
| Missing a Javadoc comment. |
36
|
|
| Name 'value' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
36
|
|
| Parameter label should be final. |
54
|
|
| 'label' hides a field. |
54
|
|
| Parameter value should be final. |
54
|
|
| 'value' hides a field. |
54
|
|
| Method 'setLabel' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
| Parameter label should be final. |
66
|
|
| 'label' hides a field. |
66
|
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
| Parameter value should be final. |
77
|
|
| 'value' hides a field. |
77
|
|
| Method 'getLabel' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
99
|
com/pow2/util/NumberUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.text.*. |
27
|
|
| Utility classes should not have a public or default constructor. |
41
|
|
| 'static' modifier out of order with the JLS suggestions. |
44
|
|
| Name 'cat' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
44
|
|
| Parameter value should be final. |
56
|
|
| Parameter value should be final. |
70
|
|
| Parameter value should be final. |
84
|
|
| Parameter pattern should be final. |
84
|
com/pow2/util/ReflectionUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.io.*. |
26
|
|
| Using the '.*' form of import should be avoided - java.lang.reflect.*. |
27
|
|
| Utility classes should not have a public or default constructor. |
35
|
|
| Line is longer than 80 characters. |
37
|
|
| Missing a Javadoc comment. |
37
|
|
| 'static' modifier out of order with the JLS suggestions. |
37
|
|
| Name 'cat' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
37
|
|
| Parameter className should be final. |
50
|
|
| Parameter constructorArgsTypes should be final. |
51
|
|
| Parameter constructorArgs should be final. |
52
|
|
| Parameter o should be final. |
67
|
|
| 'catch' is not followed by whitespace. |
80
|
|
| Parameter c should be final. |
96
|
|
| 'catch' is not followed by whitespace. |
109
|
|
| Unused @param tag for 'name'. |
121
|
|
| Unused @param tag for 'w'. |
122
|
|
| Parameter o should be final. |
124
|
|
| Expected @param tag for 'o'. |
124
|
|
| Parameter os should be final. |
124
|
|
| Expected @param tag for 'os'. |
124
|
|
| Unused @param tag for 'name'. |
134
|
|
| Parameter o should be final. |
137
|
|
| Expected @param tag for 'o'. |
137
|
|
| Parameter w should be final. |
137
|
|
| Parameter name should be final. |
149
|
|
| Parameter os should be final. |
149
|
|
| Parameter name should be final. |
162
|
|
| Parameter w should be final. |
162
|
|
| 'catch' is not followed by whitespace. |
171
|
|
| Unused @param tag for 'name'. |
189
|
|
| Parameter o should be final. |
192
|
|
| Expected @param tag for 'o'. |
192
|
|
| Parameter dumpValues should be final. |
192
|
|
| Expected @param tag for 'dumpValues'. |
192
|
|
| Parameter w should be final. |
192
|
|
| 'if' construct must use '{}'s. |
201
|
|
| Array brackets at illegal position. |
205
|
|
| 'if' construct must use '{}'s. |
209
|
|
| 'else' construct must use '{}'s. |
211
|
|
| 'catch' is not followed by whitespace. |
223
|
|
| Parameter c should be final. |
242
|
|
| 'if' construct must use '{}'s. |
244
|
|
| 'for' construct must use '{}'s. |
259
|
|
| Parameter pw should be final. |
279
|
|
| Parameter c should be final. |
279
|
|
| Array brackets at illegal position. |
282
|
|
| 'if' construct must use '{}'s. |
286
|
|
| '+' should be on a new line. |
289
|
|
| 'if' construct must use '{}'s. |
296
|
|
| Parameter pw should be final. |
307
|
|
| Parameter c should be final. |
307
|
|
| Array brackets at illegal position. |
310
|
|
| 'if' construct must use '{}'s. |
314
|
|
| '+' should be on a new line. |
317
|
|
| '+' should be on a new line. |
318
|
|
| Line is longer than 80 characters. |
334
|
|
| Parameter pw should be final. |
334
|
|
| Parameter o should be final. |
334
|
|
| Parameter dumpValues should be final. |
334
|
|
| Expected @throws tag for 'Exception'. |
335
|
|
| Array brackets at illegal position. |
339
|
|
| 'if' construct must use '{}'s. |
343
|
|
| '+' should be on a new line. |
347
|
|
| '+' should be on a new line. |
348
|
|
| 'if' construct must use '{}'s. |
357
|
|
| 'catch' is not followed by whitespace. |
367
|
|
| 'if' construct must use '{}'s. |
379
|
|
| Parameter pw should be final. |
390
|
|
| Parameter parameters should be final. |
390
|
|
| Array brackets at illegal position. |
390
|
|
| 'if' construct must use '{}'s. |
396
|
com/pow2/util/SQLUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line has trailing spaces. |
6
|
|
| Line has trailing spaces. |
11
|
|
| Line has trailing spaces. |
13
|
|
| Line has trailing spaces. |
14
|
|
| Line has trailing spaces. |
17
|
|
| Line has trailing spaces. |
18
|
|
| Line has trailing spaces. |
20
|
|
| Line has trailing spaces. |
21
|
|
| Utility classes should not have a public or default constructor. |
34
|
|
| Parameter dateString should be final. |
44
|
|
| Line contains a tab character. |
46
|
|
| Parameter dateString should be final. |
59
|
|
| Parameter format should be final. |
59
|
|
| Line contains a tab character. |
61
|
|
| Line contains a tab character. |
62
|
|
| Line contains a tab character. |
63
|
|
| Line contains a tab character. |
64
|
|
| Line contains a tab character. |
65
|
com/pow2/util/Serializer.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Class Serializer should be declared as final. |
42
|
|
| Line is longer than 80 characters. |
45
|
|
| 'static' modifier out of order with the JLS suggestions. |
45
|
|
| Name 'cat' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
45
|
|
| Parameter buf should be final. |
61
|
|
| 'if' construct must use '{}'s. |
75
|
|
| Parameter obj should be final. |
91
|
|
| 'if' construct must use '{}'s. |
108
|
|
| Parameter oldObj should be final. |
123
|
|
| 'if' construct must use '{}'s. |
147
|
|
| 'if' construct must use '{}'s. |
148
|
com/pow2/util/ServletUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Unused import - java.io.IOException. |
28
|
|
| Unused import - javax.servlet.ServletException. |
33
|
|
| Utility classes should not have a public or default constructor. |
46
|
|
| Line is longer than 80 characters. |
61
|
|
| Parameter request should be final. |
61
|
|
| Parameter args should be final. |
61
|
|
| 'if' construct must use '{}'s. |
76
|
|
| 'if' construct must use '{}'s. |
81
|
|
| Parameter req should be final. |
95
|
|
| Parameter req should be final. |
119
|
|
| Line is longer than 80 characters. |
133
|
|
| Parameter req should be final. |
133
|
|
| Parameter path should be final. |
133
|
|
| Line is longer than 80 characters. |
135
|
|
| Avoid inline conditionals. |
135
|
|
| Line is longer than 80 characters. |
151
|
|
| Line is longer than 80 characters. |
153
|
|
| Parameter req should be final. |
153
|
|
| Parameter attribute should be final. |
153
|
|
| 'if' construct must use '{}'s. |
157
|
|
| Parameter req should be final. |
177
|
|
| Parameter path should be final. |
177
|
|
| Line is longer than 80 characters. |
196
|
|
| Parameter req should be final. |
196
|
|
| Parameter path should be final. |
196
|
|
| Parameter mode should be final. |
196
|
|
| 'if' construct must use '{}'s. |
204
|
|
| 'if' construct must use '{}'s. |
207
|
|
| Unused @throws tag for 'ServletException'. |
220
|
|
| Unused @throws tag for 'IOException'. |
221
|
|
| Parameter req should be final. |
223
|
|
| Line is longer than 80 characters. |
227
|
|
| 'while' construct must use '{}'s. |
236
|
|
| Line is longer than 80 characters. |
242
|
|
| Line is longer than 80 characters. |
251
|
|
| 'if' construct must use '{}'s. |
263
|
|
| Line has trailing spaces. |
274
|
|
| 'cast' is not followed by whitespace. |
278
|
|
| 'cast' is not followed by whitespace. |
279
|
|
| Line has trailing spaces. |
281
|
|
| '=' is not preceded with whitespace. |
282
|
|
| '=' is not followed by whitespace. |
282
|
|
| Line has trailing spaces. |
290
|
|
| Line has trailing spaces. |
297
|
|
| Name 'Params' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
309
|
|
| 'if' construct must use '{}'s. |
324
|
com/pow2/util/Util.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
29
|
|
| Utility classes should not have a public or default constructor. |
40
|
|
| Parameter str should be final. |
53
|
|
| Parameter tokenSeparator should be final. |
53
|
|
| Parameter s should be final. |
65
|
|
| Parameter s should be final. |
81
|
|
| Parameter val should be final. |
81
|
|
| Parameter t should be final. |
95
|
|
| Parameter v should be final. |
121
|
|
| Avoid inline conditionals. |
125
|
|
| Parameter table should be final. |
137
|
|
| Parameter html should be final. |
137
|
|
| 'if' construct must use '{}'s. |
144
|
|
| 'while' construct must use '{}'s. |
147
|
|
| Expected an @return tag. |
163
|
|
| Line is longer than 80 characters. |
163
|
|
| Parameter URL should be final. |
163
|
|
| Name 'URL' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
163
|
|
| Parameter paramName should be final. |
163
|
|
| Parameter paramValue should be final. |
163
|
|
| Line is longer than 80 characters. |
178
|
|
| Expected an @return tag. |
180
|
|
| Parameter URL should be final. |
180
|
|
| Name 'URL' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
180
|
|
| Parameter parameter should be final. |
180
|
|
| 'if' construct must use '{}'s. |
184
|
|
| 'else' construct must use '{}'s. |
186
|
|
| Parameter str should be final. |
204
|
|
| Parameter until should be final. |
204
|
|
| 'if' construct must use '{}'s. |
209
|
com/pow2/util/VelocityUtil.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Line is longer than 80 characters. |
15
|
|
| Using the '.*' form of import should be avoided - java.io.*. |
23
|
|
| Using the '.*' form of import should be avoided - org.apache.log4j.*. |
25
|
|
| Using the '.*' form of import should be avoided - org.apache.velocity.*. |
26
|
|
| Using the '.*' form of import should be avoided - org.apache.velocity.app.*. |
27
|
|
| Using the '.*' form of import should be avoided - org.apache.velocity.exception.*. |
28
|
|
| Utility classes should not have a public or default constructor. |
37
|
|
| Line is longer than 80 characters. |
40
|
|
| 'static' modifier out of order with the JLS suggestions. |
40
|
|
| Name 'cat' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
40
|
|
| Parameter context should be final. |
52
|
|
| Parameter templateName should be final. |
52
|
|
| Line is longer than 80 characters. |
62
|
|
| Line is longer than 80 characters. |
66
|
|
| Line is longer than 80 characters. |
70
|
|
| Line is longer than 80 characters. |
86
|
com/pow2/util/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
